Skip to content

github command remains as foreground process until killed #238

@shiftkey

Description

@shiftkey

As part of reviewing #231 I noticed that running github from a terminal (without parameters) would launch the app and wait for it to complete. My thinking here is that a GUI app should result in a background process, rather than block the terminal until it's closed, but maybe I'm missing something.

The same behaviour also occurs when you have parameters, e.g. github open [path].

These scenarios worked as expected:

  • github & -> program runs as a background process, window launches
  • github [arguments] when application is already open -> window receives focus, prompt appears

cc @jfgordon2 for thoughts

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions