Wayland incompatible name of .desktop file, should be GitHub Desktop.desktop #1176
Description
The problem
You have the same problem like Signal and other Electron applications have when running under Wayland. The app icon is incorrect. See the attached screenshot of Signal, but it applies to GitHub Desktop as well.
Currently, Wayland expects the desktop file name to be the same as the "app id". You can find out that id by running WAYLAND_DEBUG=1 github-desktop, you will see that it is GitHub Desktop.
So if you under Wayland, just test this by renaming the desktop file to GitHub Desktop.desktop and start the app again. You will see that now the icon is correct.
I wrote a lengthy comment in the signal issue tracker too already with more details, take a look, there are also other links which provide even more information (the ones that point to https://aur.archlinux.org/ ...)
Caution
Be aware that changing the desktop file name might break the MIME Type handling (in your case when you authorize users in the browser on GitHub and then expect GitHub Desktop to take over from there). Not sure though, but you should test that.
Release version
3.4.8 Linux RC1
Operating system
Arch Linux with KDE Plasma 6.2 under Wayland
Steps to reproduce the behavior
No response
Log files
No response
Screenshots
From Signal, but also applies to GitHub Desktop:
Additional context
No response