Skip to content

Add early exit for grep --delete-matched when no patterns remain#505

Merged
shenwei356 merged 1 commit intoshenwei356:masterfrom
sawyerknoblich:stop-when-no-remaining-patterns
Jan 29, 2025
Merged

Add early exit for grep --delete-matched when no patterns remain#505
shenwei356 merged 1 commit intoshenwei356:masterfrom
sawyerknoblich:stop-when-no-remaining-patterns

Conversation

@sawyerknoblich
Copy link
Contributor

This PR adds an early exit to grep when there aren't any patterns left to search for, such as when using --delete-matched and all patterns have already been matched. In this case, we know we will never print anything else after all patterns have been matched, so we don't need to read any more of the file (which could take quite a long time depending on how large the file is and how far we have already read).

I also added a simple test for grep --delete-matched to help check the basic functionality, which asserts that only the first match for a pattern is returned. I couldn't think of a good way to also check that the grep exits early and the rest of the file isn't read though, but I figured this test at least helps ensure that I didn't break anything with this change.

@shenwei356
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants