Add early exit for grep --delete-matched when no patterns remain#505
Merged
shenwei356 merged 1 commit intoshenwei356:masterfrom Jan 29, 2025
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an early exit to
grepwhen there aren't any patterns left to search for, such as when using--delete-matchedand all patterns have already been matched. In this case, we know we will never print anything else after all patterns have been matched, so we don't need to read any more of the file (which could take quite a long time depending on how large the file is and how far we have already read).I also added a simple test for
grep --delete-matchedto help check the basic functionality, which asserts that only the first match for a pattern is returned. I couldn't think of a good way to also check that the grep exits early and the rest of the file isn't read though, but I figured this test at least helps ensure that I didn't break anything with this change.