Skip to content

chore: switch to shelljs-changelog#64

Merged
nfischer merged 3 commits intomasterfrom
chore-changelog-dep
Jun 18, 2016
Merged

chore: switch to shelljs-changelog#64
nfischer merged 3 commits intomasterfrom
chore-changelog-dep

Conversation

@nfischer
Copy link
Copy Markdown
Member

Same script, but now it's refactored out as a dependency, and it runs in Node instead of bash.

@levithomason
Copy link
Copy Markdown
Contributor

I'd think keeping the cli namespaced shelljs-changelog or shx-changelog would be a good idea. This PR however LGTM!

@nfischer
Copy link
Copy Markdown
Member Author

SGTM. I'll update that for the next version of the changelog and release scripts

@nfischer
Copy link
Copy Markdown
Member Author

This is bumped to the most recent version of shelljs-changelog, with the namespaced CLI.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 15, 2016

Current coverage is 88.88%

Merging #64 into master will not change coverage

@@             master        #64   diff @@
==========================================
  Files             2          2          
  Lines             9          9          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits              8          8          
  Misses            1          1          
  Partials          0          0          

Powered by Codecov. Last updated by c9065dd...902bda6

@ariporad
Copy link
Copy Markdown
Contributor

LGTM, but could you fix the merge errors? Thx

@nfischer nfischer merged commit aa925e2 into master Jun 18, 2016
@nfischer nfischer deleted the chore-changelog-dep branch June 18, 2016 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants