Skip to content

Small clarification of verbose flag#691

Merged
nfischer merged 3 commits intoshelljs:masterfrom
zommerfelds:patch-1
Mar 31, 2017
Merged

Small clarification of verbose flag#691
nfischer merged 3 commits intoshelljs:masterfrom
zommerfelds:patch-1

Conversation

@zommerfelds
Copy link
Copy Markdown
Contributor

Hi, just though this might be useful for someone. I had to run a test manually to see if custom exec commands also show up as verbose.

@nfischer
Copy link
Copy Markdown
Member

@zommerfelds thanks for the PR. After looking over this, maybe it would also be good to show a command with options. How about:

rm('-rf', 'foo.txt', 'bar.txt'); ➡️ rm -rf foo.txt bar.txt

Maybe this could replace the ls example, since it doesn't add much to the cd example.

@zommerfelds
Copy link
Copy Markdown
Contributor Author

@nfischer: Sorry for the delay on this one! I made your suggested changes.

@nfischer
Copy link
Copy Markdown
Member

@zommerfelds Can you make the change in the corresponding source file? README docs are autogenerated. After you change that file, you can run npm run gendocs. Thanks!

Other than that, LGTM.

@zommerfelds
Copy link
Copy Markdown
Contributor Author

Hi @nfischer. I hadn't noticed that this was auto generated. Just added the change to the source file and regenerated the Readme.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 31, 2017

Codecov Report

Merging #691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          33       33           
  Lines        1183     1183           
=======================================
  Hits         1120     1120           
  Misses         63       63
Impacted Files Coverage Δ
shell.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9201eb...0d39395. Read the comment docs.

@nfischer nfischer merged commit 80d590e into shelljs:master Mar 31, 2017
@nfischer
Copy link
Copy Markdown
Member

Thanks!

@zommerfelds zommerfelds deleted the patch-1 branch March 31, 2017 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants