Modified glob pattern. Fixes #666#676
Merged
nfischer merged 1 commit intoshelljs:masterfrom Mar 1, 2017
Merged
Conversation
Closed
nfischer
requested changes
Feb 28, 2017
| glob.sync(p + globPatternRecursive, { dot: options.all, follow: options.link }) | ||
| .forEach(function (item) { | ||
| pushFile(item, path.relative(p, item)); | ||
| if (path.relative(p, item)) { |
Member
There was a problem hiding this comment.
Could you add a comment explaining that this is because the glob pattern returns the directory itself? Otherwise, LGTM
Contributor
Author
|
@nfischer Comment added 👍 |
nfischer
approved these changes
Feb 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #669
This PR continues #665 and fixes #666.
From
node-globrepo:Therefore, the current pattern (
/**/*) takes the first level of files inside symlinked directories. This PR changes it to/**which does not follow symlinks.Now both
lsandfindonly show the symlink directory as a single entry.ls -RLfollows it.