Conversation
freitagbr
requested changes
Feb 17, 2017
README.md
Outdated
| @@ -1,33 +1,34 @@ | |||
| # ShellJS - Unix shell commands for Node.js | |||
| # ShellJS - Unix shell commands for NodeJS | |||
Contributor
There was a problem hiding this comment.
We should stick with "Node.js", as that is the official name.
| commands. You can also install it globally so you can run it from outside Node | ||
| projects - say goodbye to those gnarly Bash scripts! | ||
|
|
||
| ShellJS is proudly tested on every node release since `v0.11`! |
Contributor
There was a problem hiding this comment.
We're only testing on v4 and up now right? Maybe we should change this to v4.
Member
Author
There was a problem hiding this comment.
That hasn't been merged to master branch yet, only dev. And I think that README change already exists in the dev branch.
We could just as well base this PR off dev, instead. No hurry.
Contributor
There was a problem hiding this comment.
Ah, right. Let's leave this as v0.11 for now.
| ## Team | ||
|
|
||
| | [](https://github.com/nfischer) | [](http://github.com/ariporad) | | ||
| | [](https://github.com/nfischer) | [](http://github.com/freitagbr) | |
31cb653 to
830dded
Compare
Member
Author
|
@freitagbr PTAL. I changed |
Contributor
|
One of the "NodeJS" occurrences is in the |
- Add @freitagbr to the bottom of the README - Remove docs about shjs (it's not well supported) - Remove docs about coffeescript (we don't do anything special for coffeescript anyway) - Modify the section about shelljs/global, since we strongly recommend avoiding this now - Rewrite the code example to use `require('shelljs')` instead of shelljs/global - Mention ESLint next to JSHint - Reformat sections with long lines to be 80 columns
830dded to
97ae328
Compare
Member
Author
|
@freitagbr PTAL. Thanks for catching this |
Contributor
|
LGTM 👍 |
freitagbr
approved these changes
Mar 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coffeescript anyway)
avoiding this now
require('shelljs')instead ofshelljs/global