refactor: add config.reset() and .resetForTesting()#641
Merged
Conversation
Member
Author
|
@freitagbr this should be passing all tests now. Let me know if you think we should document |
freitagbr
requested changes
Jan 8, 2017
src/common.js
Outdated
| Object.assign(this, DEFAULT_CONFIG); | ||
| }, | ||
| resetForTesting: function () { | ||
| Object.assign(this, DEFAULT_CONFIG); |
Contributor
There was a problem hiding this comment.
These should be objectAssign.
Member
Author
There was a problem hiding this comment.
Whoops, forgot to push the fix. Yeah, this should work now
965b041 to
91e30bc
Compare
Contributor
|
Let's also add documentation for shell.config.reset()Reset the configuration to the following defaults: Other than that, LGTM. |
91e30bc to
040f743
Compare
040f743 to
8201591
Compare
Add .reset() and .resetForTesting() to shell.config and use .resetForTesting() as a standard set-up for unit tests.
8201591 to
85c637a
Compare
freitagbr
approved these changes
Jan 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
.reset()and.resetForTesting()toshell.configand use.resetForTesting()as a standard set-up for unit tests.This also adds
npm run test-no-coverage, since testing with coverage every time gets pretty slow..reset()is implicitly tested by checking default values forshell.config..resetForTesting()is relied upon by all unit tests.