fix: allow non-normalized paths as input to mkdir#635
Merged
Conversation
Adds tests to make sure that non-normalized paths (i.e. path/to/./dir) are valid for a few commands, including mkdir() which previously failed when given the -p flag. Fixes #634
freitagbr
reviewed
Jan 5, 2017
| try { | ||
| if (options.fullpath) { | ||
| mkdirSyncRecursive(dir); | ||
| mkdirSyncRecursive(path.resolve(dir)); |
Contributor
There was a problem hiding this comment.
It seems like fs.mkdirSync normalizes the path passed to it anyway. Is that why path.resolve is not needed below?
Member
Author
There was a problem hiding this comment.
Yes, that's correct.
It's needed here because, for each recursive call, we process another piece of the path. This can lead us to processing something that isn't valid for mkdir, like . or ... It can also lead us to processing the same directory twice (ex. foo/../foo/) which also isn't valid.
Member
Author
|
@freitagbr LGTY? |
Contributor
|
Yes, LGTM. |
freitagbr
approved these changes
Jan 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests to make sure that non-normalized paths (i.e. path/to/./dir) are
valid for a few commands, including mkdir() which previously failed when given
the -p flag.
Fixes #634