Conversation
9f2f583 to
b4a6ca4
Compare
freitagbr
requested changes
Nov 25, 2016
|
|
||
| // TODO(nate): make sure this does not have a false negative if 'git' is missing | ||
| test('basic usage', t => { | ||
| const git = shell.which('git'); |
Contributor
There was a problem hiding this comment.
Why not use node? Surely if this test is running on a system, that system has node installed...
Member
Author
There was a problem hiding this comment.
Node can be installed as nodejs on Linux. It's always installed as node.exe on Windows, though. We can count on git to be always be installed on a dev's box. That's the rationale. We could probably change the next one to git as well if we wanted to be consistent
Contributor
There was a problem hiding this comment.
That's a good point, let's keep it git then.
freitagbr
approved these changes
Nov 26, 2016
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@freitagbr ready for review. This should be good to go.