Conversation
freitagbr
requested changes
Nov 23, 2016
ava-test/chmod.js
Outdated
| t.is(result.code, 0); | ||
| }); | ||
|
|
||
| test('No Test Title #27', t => { |
Contributor
There was a problem hiding this comment.
We need a title for this test, though I'm not sure what it's testing.
Member
Author
There was a problem hiding this comment.
I think this was actually a cleanup step before. There's no harm in running these lines and making sure they succeed though, so I kept them.
ava-test/chmod.js
Outdated
| }); | ||
|
|
||
| // TODO(nate): fix this description | ||
| test('Test files - the bitmasking is to ignore the upper bits.', t => { |
Contributor
There was a problem hiding this comment.
Fix this description too?
3903c45 to
a9de528
Compare
a9de528 to
649ac27
Compare
Member
Author
|
@freitagbr PTAL.
|
Contributor
|
LGTM |
freitagbr
approved these changes
Nov 23, 2016
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR, so double check that I got all the test cases. I'll follow up once I've verified that this translates everything correctly.