Skip to content

test: refactor cat tests to ava#564

Merged
nfischer merged 2 commits intomasterfrom
test-ava-cat
Nov 20, 2016
Merged

test: refactor cat tests to ava#564
nfischer merged 2 commits intomasterfrom
test-ava-cat

Conversation

@nfischer
Copy link
Copy Markdown
Member

No description provided.

@nfischer
Copy link
Copy Markdown
Member Author

@freitagbr I'm pretty confident that all tests have been properly converted. Feel free to review this for style.

ava-test/cat.js Outdated

test.beforeEach(() => {
shell.config.silent = true;
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? In the old code, this is only configured once, not reconfigured before every test. I think this can be simplified to just this:

test.before(() => {
    shell.config.silent = true;
});

Or even more simply to this:

shell.config.silent = true;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it each time should be harmless. But since it slows things down, it should be fine to move it out to just once before.

@nfischer
Copy link
Copy Markdown
Member Author

@freitagbr PTAL

@freitagbr
Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@nfischer
Copy link
Copy Markdown
Member Author

LGTM

@nfischer
Copy link
Copy Markdown
Member Author

Merging, since it looks like lgtm.co is broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants