Update sed documentation regarding capture groups#558
Merged
freitagbr merged 3 commits intoshelljs:masterfrom Nov 18, 2016
freitagbr:sed-documentation
Merged
Update sed documentation regarding capture groups#558freitagbr merged 3 commits intoshelljs:masterfrom freitagbr:sed-documentation
freitagbr merged 3 commits intoshelljs:masterfrom
freitagbr:sed-documentation
Conversation
nfischer
requested changes
Nov 17, 2016
src/sed.js
Outdated
| //@ | ||
| //@ Note: | ||
| //@ | ||
| //@ Unix `sed` specifies capture groups using `\n` syntax. In ShellJS (and JavaScript, in general), |
Member
There was a problem hiding this comment.
Don't use \n, since that sounds like the newline character. It might suffice to just provide the javascript example and skip the shell code, for brevity's sake.
Contributor
Author
There was a problem hiding this comment.
You're right, it would probably be best to just mention sed's capture groups by name, and then show the JS example.
Member
|
@freitagbr LGTM once you regenerate docs |
nfischer
approved these changes
Nov 17, 2016
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507