Fix: Remove default glob from shell.test (fixes #529)#530
Merged
nfischer merged 1 commit intoshelljs:masterfrom Oct 17, 2016
gyandeeps:issue529
Merged
Fix: Remove default glob from shell.test (fixes #529)#530nfischer merged 1 commit intoshelljs:masterfrom gyandeeps:issue529
nfischer merged 1 commit intoshelljs:masterfrom
gyandeeps:issue529
Conversation
Member
|
LGTM. Thanks for the fix. @gyandeeps did you find any other commands that had a similar mistake? If not, I can merge this tomorrow. |
Contributor
Author
|
This s the only I was sure about. |
Member
|
I can't find any other regressions. This should be great, thanks for catching this! |
Contributor
Author
|
@nfischer When is the plan to make a release with this fix? Just wanted to know. Thanks |
Member
|
I need to take a look at our recent commits, but I think we can get this out as a patch release pretty soon. I also want to push out some plugin-related features to begin dogfooding them, but I should be wrapping those up soon. We can probably get this out within the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #492