refactor: allow pipeOnly commands (methods on ShellStrings)#493
Merged
refactor: allow pipeOnly commands (methods on ShellStrings)#493
Conversation
Contributor
|
LGTM! |
Contributor
|
Force-merging this because LGTM isn't working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487
This implements the
pipeOnlyoption towrapOptions. This is false by default.This checks for conflicts between
pipeOnlyandcanReceivePipeand throws an exception.This also refactors some code to take advantage of these new changes. Two test cases were modified in order to give better error messages (in case globbing ever breaks for
.to()or.toEnd()).