refactor: add wrapOutput option to auto-ShellString-ify command output#481
Merged
refactor: add wrapOutput option to auto-ShellString-ify command output#481
Conversation
Contributor
|
LGTM! |
467a10d to
0a8cacf
Compare
Member
Author
|
This is just updated to resolve the conflicts introduced by #479. I'm going to re- LGTM this, since it's pretty trivial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets you return a plain JS string (like before), but pass the
wrapOutputoption tocommon.register()in order to wrap this string in a ShellString. This wraps it with the following default parameters (which I think will work properly most of the time):By default,
common.register()works as before (so collaborators must opt-in for this feature). This lets functions return non-string output, or return a custom-built ShellString (if these default values aren't suitable).Do not merge until after #479 is either closed or merged