Work in progress: pushd/popd/dirs#47
Work in progress: pushd/popd/dirs#47arturadib merged 11 commits intoshelljs:masterfrom mstade:pushd-popd-dirs
Conversation
shell.js
Outdated
There was a problem hiding this comment.
semi-colons for consistency with the current code :) thanks!
|
hey Marcus! many thanks for your contributions. I've left some comments but if you don't have time to address them, I'd be happy to - I just wanted to leave some bookmarks of places I'd need to revisit. superb work, many thanks! let me know if you want me do handle the comments. |
|
Excellent feedback, thanks! I figured I'd get some visibility on the work so I can get your direction so I'm in line with project conventions. As you can probably tell, I'm in the semicolons-meh camp, but I'm trying hard to adjust! ;o) I'll try to get a couple of hours in on this tonight to fix the things you mention, as well as add the missing |
|
I've changed the return values to be an array representing the stack now. Should the commands also log the stack when invoked, like their shell counterparts do? Currently they only log errors (by invoking |
Added pwd check to all tests, and added a test for invalid use of popd. More tests to come.
|
thanks Marcus - ready to merge, unless you're still working on the tests |
|
Some more tests wouldn't hurt I think. I still need to make sure the options have tests as well as invalid usage (e.g. |
I started work on #24. Currently, pretty much just started looking at pushd and popd; dirs has the most basic implementation with no options supported currently. Tests are optimistic and too simple. Comments more than welcome!