refactor: expose pipe-ability to command configuration#464
Merged
Conversation
Contributor
|
LGTM! |
Member
Author
|
Updated this to have slightly clearer identifier names. Unless the new names are an issue, I'll go ahead and merge this after CI completes. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is one of the first steps we'll need to take in order to create a better setup for creating new commands/plugins. Now, contributors need only specify that their command can receive input from a pipe with the
receivesPipeoption set totrue, instead of modifying the array that used to explicitly contain each command that could receive input from a pipe.This cuts out one more spot where contributors need to make a modification.