issue-407: Add regular files unit tests and fix symlink copy behavior#409
Merged
ariporad merged 2 commits intoshelljs:masterfrom Mar 27, 2016
charlesverge:issue-407
Merged
issue-407: Add regular files unit tests and fix symlink copy behavior#409ariporad merged 2 commits intoshelljs:masterfrom charlesverge:issue-407
ariporad merged 2 commits intoshelljs:masterfrom
charlesverge:issue-407
Conversation
Member
|
LGTM |
Member
|
@charlesverge This looks perfect! Nice work. |
Author
|
@nfischer I added an additional commit to handle windows permissions, copied from test/ln.js Also an additional check that the combo of -r and -L does not change behavior. |
added 2 commits
March 24, 2016 22:32
…cases to handle non admin windows test execution
Member
|
LGTM |
Member
|
@ariporad Feel free to merge if this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #407 , includes test case for basic cp -L commands and additional cp -RL test case