Skip to content

Added -n to cp#192

Closed
SerenadeX wants to merge 2 commits intoshelljs:masterfrom
SerenadeX:master
Closed

Added -n to cp#192
SerenadeX wants to merge 2 commits intoshelljs:masterfrom
SerenadeX:master

Conversation

@SerenadeX
Copy link
Copy Markdown

No description provided.

@SerenadeX
Copy link
Copy Markdown
Author

The -n option allows the user to copy things from one directory to another without overwriting existing files in the destination

@arturadib
Copy link
Copy Markdown
Collaborator

hey there- sorry I'm late to this. mind modifying the test to actually check the file contents to ensure the file wasn't overwritten? thanks!

@bruce-one bruce-one mentioned this pull request Oct 8, 2015
@nfischer
Copy link
Copy Markdown
Member

@SerenadeX would you be able to address the comment above from @arturadib? If so, I'd be interested in merging!

Also, would you be able to rebase off master?

@ariporad ariporad added feature bash compat Compatibility issues with bash or POSIX behavior labels Jan 29, 2016
@nfischer
Copy link
Copy Markdown
Member

nfischer commented Feb 9, 2016

@SerenadeX Thank you so much for the PR! I think we'll have to close this, however, since this is replaced by #336. Thanks for the idea!

@nfischer nfischer closed this Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash compat Compatibility issues with bash or POSIX behavior blocked feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants