Skip to content

fix: cmd is compatible with node 22.10 #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nfischer merged 1 commit into from
Apr 10, 2025
Merged

fix: cmd is compatible with node 22.10 #1219

nfischer merged 1 commit into from
Apr 10, 2025
+11 −3

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Apr 10, 2025

Starting in node >= 22.10.0, a commandNotFound error will have undefined values for stdout/stderr, whereas in earlier versions these values were null.

Fixes #1180

@nfischer
fix: cmd is compatible with node 22.10
1d9485f 
Starting in node >= 22.10.0, a commandNotFound error will have
`undefined` values for stdout/stderr, whereas in earlier versions these
values were `null`.

Fixes #1180
@nfischer nfischer added fix Bug/defect, or a fix for such a problem exec Issues specific to the shell.exec() API labels Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (8bc5833) to head (1d9485f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          35       35           
  Lines        1409     1410    +1     
=======================================
+ Hits         1372     1373    +1     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer merged commit 75d26de into main Apr 10, 2025
20 checks passed
@nfischer nfischer deleted the fix-cmd-node-22 branch April 10, 2025 08:27
@renovate renovate bot mentioned this pull request May 22, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

exec Issues specific to the shell.exec() API fix Bug/defect, or a fix for such a problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nodejs v22.10.0 onward give errors: void node::fs::InternalModuleStat(const v8::FunctionCallbackInfo<v8::Value>&)

2 participants

@nfischer