feat: integrate vet for secure script execution fallback#58
Open
scuba3198 wants to merge 4 commits intosheeki03:mainfrom
Open
feat: integrate vet for secure script execution fallback#58scuba3198 wants to merge 4 commits intosheeki03:mainfrom
scuba3198 wants to merge 4 commits intosheeki03:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ea66d1375
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Description
This PR integrates vet into the
tirith runexecution pipeline to provide a seamless, secure fallback for shell script execution. When enabled, it replaces the default interactive prompt with an automatic handoff to vet, which provides its own diff inspection and interactive execution guard.Changes Included
false).use_vet_runner: trueand vet is available inPATH, the script's origin URL is seamlessly passed into vet.use_vet_runner: truebut vet is not installed, it safely warns the user and falls back to the defaulttirithwarning system.whichdependency to safely check for the vet binary.dead_codeandunused_importwarnings across webhook.rs, audit_upload.rs, and assets.rs to achieve a0warnings baseline because running cargo clippy --workspace --all-targets -- -D warnings (which is standard practice to ensure code quality) was failing my local builds due to these existing warnings, and I wanted to ensure my PR passed strict CI checks without introducing any new noise.Testing
cargo buildandcargo fmtsucceed with zero errors.cargo clippy --workspace --all-targets -- -D warningsfinishes with zero warnings.cargo test --workspacefully succeeds (163/163 pass).file://protocol injection to force 🦀 vet to audit the local cache and eliminate any TOCTOU race conditions.Note
Delegate
tirith-core::runner.runto externalvetwhen policyuse_vet_runneris true and awhich-resolvedvetbinary is availableAdd policy flag
policy::Policy.use_vet_runnerwith#[serde(default)], passcwdviatirith-core::runner::RunOptions, and conditionally invokevetusing afile://URI for the cached script with fallback to existing execution; update CLI to setcwdand add docs for configuration in cookbook.md.📍Where to Start
Start with the delegation path in
tirith-core::runner::runin runner.rs.Macroscope summarized c545532.