[TF2] Add correct bounding box values for shavit_zones_box_offset#1179
[TF2] Add correct bounding box values for shavit_zones_box_offset#1179rtldg merged 4 commits intoshavitush:masterfrom
Conversation
Yeah, I think you're right about it not being desired/expected/optimal with |
Or should I? |
Not a bad idea. Guess it depends how much control you want to give people. I guess 3 main solutions for this:
|
|
Ended up adding a commit to make it act like a bool & to do the height too. |
TF2's bounding box is
48x48x82compared to CS:S32x32x62and CS:GO32x32x72. As such, the default value of gCV_BoxOffset (bbox width / 2) is slightly off the player's center for TF2.In SetZoneMinsMaxs, the
heightvariable is half the bbox height but does not use the correct value for TF2 either (uses CS:S 62.0 instead of 82.0). This PR adds the correct bbox values for TF2.As an aside, I did wonder if having
heightbe constantly set to half the bbox height is really the desired behavior. E.g. ifshavit_zones_box_offset = 0, why should distance_z be offset by half the bbox height yet have no offset for distance_x/y?bhoptimer/addons/sourcemod/scripting/shavit-zones.sp
Lines 5104 to 5114 in a6da435