Merged
Conversation
As a testing strategy we'll generate apps that pretend to be buildpacks using the "inline" buildpack. We can then use this along with Hatchet to test our buildpack behavior. Adding in these tests exposed a problem with the previous logic. There was a bug where if a Procfile existed but didn't contain a `release:` designation then the runtime check wouldn't be executed.
Contributor
Author
|
This accidentally runs all tests against master branch. Need to also include this commit: e76ff1a |
Contributor
Author
|
Rspec will truncate output if it is too long. You can set it to not do this by configuring: I'm also asking how to disable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a testing strategy we'll generate apps that pretend to be buildpacks using the "inline" buildpack. We can then use this along with Hatchet to test our buildpack behavior.
Adding in these tests exposed a problem with the previous logic. There was a bug where if a Procfile existed but didn't contain a
release:designation then the runtime check wouldn't be executed.