Don't output default theme info to piped stdout#3075
Merged
keith-hall merged 3 commits intosharkdp:masterfrom Oct 6, 2024
Merged
Don't output default theme info to piped stdout#3075keith-hall merged 3 commits intosharkdp:masterfrom
keith-hall merged 3 commits intosharkdp:masterfrom
Conversation
keith-hall
approved these changes
Aug 25, 2024
Collaborator
keith-hall
left a comment
There was a problem hiding this comment.
Thanks, looks good to me 🙂
Contributor
Author
|
@keith-hall This will not auto-merge because of the failing changelog check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2937 introduced the
(default)suffix to the output of--list-themes, which breaks completion scripts. This PR tries to solve that by not printing the(default)suffix when stdout is piped.Fixes #3073.