Make -pp override --paging and vice versa when passed as a later argument.#2330
Closed
vishal1132 wants to merge 1 commit intosharkdp:masterfrom
Closed
Make -pp override --paging and vice versa when passed as a later argument.#2330vishal1132 wants to merge 1 commit intosharkdp:masterfrom
-pp override --paging and vice versa when passed as a later argument.#2330vishal1132 wants to merge 1 commit intosharkdp:masterfrom
Conversation
Owner
|
Thank you. It would be great if we could add a regression test for this. |
Author
|
that makes sense @sharkdp, have a holiday here tomorrow. Will add it then. |
Collaborator
|
Closing for now to keep PR inbox clean. I considered merging this without a regression test, but by my estimation, the use case is too complicated for there to not be a regression test. Of course feel free to re-open this if work resumes on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other part of #2128 to make
-ppoverride--pagingand--pagingoverride-ppwhichever is passed as a later argument wins.