-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CI failing due to missing submodules #3363
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
The repositories https://github.com/brandonwamboldt/sublime-nginx and https://github.com/brandonwamboldt/sublime-hosts no longer exist, so CI fails to checkout the submodules when testing with all syntaxes and themes and validating licenses of our dependencies. We will need to:
- find a suitable fork if it is being actively maintained
- or vendor it ourself from a local checked out version
- or recreate a sublime-syntax from scratch and accept that highlighting will be different
- or drop the submodule and corresponding syntax highlighting
Example CI failure log:
https://github.com/sharkdp/bat/actions/runs/16695940283/job/47260077847?pr=3362
Error: fatal: repository 'https://github.com/brandonwamboldt/sublime-nginx/' not found
Error: fatal: repository 'https://github.com/brandonwamboldt/sublime-hosts/' not found
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers