CLN: remove deprecated to_wkb/to_wkt methods#974
Merged
sgillies merged 1 commit intoshapely:masterfrom Aug 29, 2020
Merged
Conversation
mwtoews
approved these changes
Aug 26, 2020
Member
mwtoews
left a comment
There was a problem hiding this comment.
These can be removed for 1.8 in my opinion, as these warnings have been in place for 7 years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that those functions and methods are already deprecated for many years. So I think those can already be removed for 1.8, but of course, since we are removing a bunch of things in 2.0, we can also directly keep this removal for 2.0 as well (in which case I can edit the PR to target the shapely-2.0 branch instead of master)