Skip to content

Revise AppVeyor setup for Windows#819

Merged
sgillies merged 2 commits intoshapely:masterfrom
mwtoews:appveyor
Jan 20, 2020
Merged

Revise AppVeyor setup for Windows#819
sgillies merged 2 commits intoshapely:masterfrom
mwtoews:appveyor

Conversation

@mwtoews
Copy link
Copy Markdown
Member

@mwtoews mwtoews commented Jan 14, 2020

  • Build GEOS version 3.8.0 using CMake/Ninja/Visual C++
  • Build wheels for 8 combinations of x86/x64 and Py35/Py36/Py37/Py38
  • Don't build wheels for Py27, as it's too difficult and a low priority
  • Remove unused scripts from previous setup

The aim of this workflow is to allow Windows users to use pip install shapely; see #367

* Build GEOS version 3.8.0 using CMake/Ninja/Visual C++
* Build wheels for 8 combinations of x86/x64 and Py35/Py36/Py37/Py38
* Don't build wheels for Py27, as it's too difficult and a low priority
* Remove unused scripts from previous setup
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 80.925% when pulling 9dd9a0c on mwtoews:appveyor into 10d6ea9 on Toblerity:master.

@sgillies
Copy link
Copy Markdown
Contributor

This looks good to me, I lack the Windows and AppVeyor expertise that might be needed to see any problems. For my part: I'll work on setting up AppVeyor support for this repo.

Related: I recently acquired the https://github.com/shapely organization and am curious to know what you'd like about moving the repo there. Toblerity is pretty obscure and shapely seems like a more normal organization name for the project and its related projects.

@mwtoews
Copy link
Copy Markdown
Member Author

mwtoews commented Jan 18, 2020

@sgillies when an AppVeyor account is created and linked to this repo, I'll add another commit to add a build status badge to README.rst and also trigger the first build.

As for potential repo move, it's your call, but I don't see any issues with it. Two things to double-check if links get redirected (e.g. would https://github.com/Toblerity/Shapely/pull/819 navigate to https://github.com/shapely/shapely/pull/819?). The second check is to ensure the issue and PR numbers are not reset to 1. My hunch is that neither of these are issues if you transfer an existing repo. Also, would Fiona and rtree follow along to the new organization name?

I'd also suggest renaming this repo name from titlecase "Shapely" to lowercase "shapely". In a possibly related curiosity, Fiona and rtree shows how many other projects depend on them with a "Used by" button at the top of the main repo website. Why does Shapely not show this?

@sgillies
Copy link
Copy Markdown
Contributor

@mwtoews I created a new "frs-ci" account on AppVeyor, made each of us members of the team with admin role, and created a new project: https://ci.appveyor.com/project/frsci/shapely.

As to the GitHub "used by" button, my understanding is that it may (or may not?) appear at some future time. It seems to be a slow rollout.

* Align them horizontally
* Add AppVeyor build status
@mwtoews
Copy link
Copy Markdown
Member Author

mwtoews commented Jan 20, 2020

This PR is now ready to be merged. Full build takes about 1 hour, but the GEOS builds are cached, so subsequent builds shouldn't take too long (~1 min x 8 in current matrix).

@sgillies sgillies merged commit 72e11ed into shapely:master Jan 20, 2020
@mwtoews mwtoews mentioned this pull request Oct 25, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants