Skip to content

Avoid floating point error for rectangular polygons in polylabel.#644

Merged
sgillies merged 2 commits intoshapely:masterfrom
snorfalorpagus:polylabel_special_case
Oct 5, 2018
Merged

Avoid floating point error for rectangular polygons in polylabel.#644
sgillies merged 2 commits intoshapely:masterfrom
snorfalorpagus:polylabel_special_case

Conversation

@snorfalorpagus
Copy link
Copy Markdown
Member

This PR adds a special case for rectangular polygons to the polylabel algorithm, present in the original JavaScript version. See mapbox/polylabel#3

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 81.127% when pulling 277b5bc on snorfalorpagus:polylabel_special_case into 5d18af2 on Toblerity:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 81.127% when pulling 277b5bc on snorfalorpagus:polylabel_special_case into 5d18af2 on Toblerity:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 3, 2018

Coverage Status

Coverage increased (+0.03%) to 81.116% when pulling 3daa0ee on snorfalorpagus:polylabel_special_case into 5d18af2 on Toblerity:master.

@sgillies sgillies added the bug label Oct 5, 2018
@sgillies sgillies added this to the 1.7 milestone Oct 5, 2018
@sgillies sgillies merged commit cfa66d4 into shapely:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants