Conversation
Pull Request Test Coverage Report for Build 13058411942Details
💛 - Coveralls |
| twine check --strict dist/* | ||
|
|
||
| - uses: actions/upload-artifact@v3 | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
See the commit that changes this on main: bc46326
I think you will have to copy over the other changes as well to make this fully working (I assume github actions will also complain about the v3 in actions/download-artifact@v3)
|
@sgillies I think it might be best that you remove the tag again from the commit in this PR. It has actually been useful that you did this to notice that the publish step is failing right now. But in general the release workflow assumes that the tag is done on the actual maint-2.0 branch (if we want to be able to test doing a release before doing the actual release, we should set up the workflow with test-pypi I assume, so we can do that from a PR first. But for now I always just released from the maint branch as described in the wiki) |
|
Yes, I see now that the Circle CI config has us building only on pushes to main and maint-2.0. I'll delete the tag, merge this and then force the tag on maint-2.0. |
Resolves #2208