CLN: remove unused _geos.pxi GEOS cython declarations#1419
Merged
jorisvandenbossche merged 2 commits intoshapely:mainfrom Jul 8, 2022
Merged
CLN: remove unused _geos.pxi GEOS cython declarations#1419jorisvandenbossche merged 2 commits intoshapely:mainfrom
jorisvandenbossche merged 2 commits intoshapely:mainfrom
Conversation
Pull Request Test Coverage Report for Build 2531144066
💛 - Coveralls |
brendan-ward
approved these changes
Jun 13, 2022
mwtoews
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cython declarations from
_geos.pxiare no longer used in Shapely itself (the previously existing cython code was removed). The new cython code from pygeos came with its own declarations at_geos.pxd(and it seems more correct to use a pxd file): https://github.com/shapely/shapely/blob/main/shapely/_geos.pxdI think we can just remove this in 2.0, as it wasn't considered as public (I assume?)