Skip to content

DOC: restructure the combined docs + new theme#1402

Merged
jorisvandenbossche merged 6 commits intomainfrom
docs-restructure
Jun 19, 2022
Merged

DOC: restructure the combined docs + new theme#1402
jorisvandenbossche merged 6 commits intomainfrom
docs-restructure

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche commented May 23, 2022

This PR does:

  • Uses a more modern sphinx theme (instead of "sphinxdoc"). There are plenty of possibilities, but I went with sphinx-book-theme, because it's a theme where I am also involved with somewhat (we use a variant of it for pandas/geopandas)
  • Restructures the index.rst: moved the "project" page to index.rst, split "changes" to its own page, divided the docs in user guide vs reference docs (in the future we could further split the "User Manual" page into multiple pages if we would want)

You can see the result live at https://shapely.readthedocs.io/en/docs-restructure/index.html

@coveralls
Copy link
Copy Markdown

coveralls commented May 23, 2022

Pull Request Test Coverage Report for Build 2412155426

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.325%

Totals Coverage Status
Change from base Build 2412147631: 0.0%
Covered Lines: 2141
Relevant Lines: 2539

💛 - Coveralls

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

What do people think of the theme and general layout? -> https://shapely.readthedocs.io/en/docs-restructure/index.html

Copy link
Copy Markdown
Collaborator

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes here @jorisvandenbossche !

I like the new layout.

It's a bit hard to judge the content of the docs cohesively since there are concurrent changes in other PRs, so I think my only real comment here is around trying to move the long list of contributors off the main page onto a dedicated page, and to think about how we want to maintain that post 2.0 (e.g., alongside release notes).

=======
.. include:: ../README.rst

.. include:: ../CREDITS.txt
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is long enough that it probably would do better on its own top level page. Alternatively, we could instead adopt the approach of numpy and pandas and list contributors for each release, but not maintain a single long list (per-release seems easier from a maintenance perspective). This list could then go into a dedicated "contributors prior to 2.0" page (not quite sure where).

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

Yes, agreed that we should reconsider how to handle the credits/contributors (keep the overall listing? Move to a separate page? List them per release?). For now this keeps it as is (include the file on the main doc page), so let's have that as a follow-up discussion / PR.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

Going to merge this as people generally seemed to like the new theme, and then we can better judge other PRs that update the docs based on the new layout/theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants