Remove logging related tests#1308
Merged
jorisvandenbossche merged 2 commits intoshapely:mainfrom Feb 24, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 1831577362
💛 - Coveralls |
caspervdw
approved these changes
Feb 24, 2022
Pull Request Test Coverage Report for Build 1799598463Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #998
The GEOS error handler is now implement to raise python Exceptions, and no longer to log the errors. The discussion in #998 concluded that we are thus fine to fully remove the logging functionality. This change already happened in practice by removing the ctypes related code / the pygeos merger. This PR removes the remaining (skipped) tests about logging.