Deprecate calling the BaseGeometry constructor + EmptyGeometry class#1303
Merged
jorisvandenbossche merged 4 commits intoshapely:mainfrom Mar 31, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 2071227143
💛 - Coveralls |
Member
|
Shouldn't this raise |
Member
Author
|
That's fine for me as well (I wasn't sure we were going to use ShapelyDeprecationWarning just for the 2.0 release, or whether we would keep using that class for other deprecations in the future as well, but either way is fine). |
caspervdw
approved these changes
Feb 24, 2022
Member
Author
|
The black installation issue is getting fixed in #1355 |
Pull Request Test Coverage Report for Build 1797393911Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1022
All the geometry subclasses can now properly create an empty geometry when called with no input (eg
Point(),Polygon()). So I personally don't see a good reason why people should doBaseGeometry(), while this is creating an empty geometry collection, soGeometryCollection()is more explicit.See #1022 for some more argumentation.