BUG: fixup the hash-ability of geometries#1239
Merged
jorisvandenbossche merged 1 commit intoshapely:mainfrom Dec 2, 2021
Merged
BUG: fixup the hash-ability of geometries#1239jorisvandenbossche merged 1 commit intoshapely:mainfrom
jorisvandenbossche merged 1 commit intoshapely:mainfrom
Conversation
caspervdw
approved these changes
Dec 1, 2021
f57a6a3 to
cca6f27
Compare
Member
Author
|
Merging this, so I can try to get the tests passing in #1241 (we can later still revisit the exact approach of doing it in C vs python) |
This was referenced Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #1237, so only the last commit is relevant.
The tests for hash-ability were still failing, for two reasons:
__hash__ = Nonein the code, effectively making a class unhashable__eq__in the python-level BaseGeometry class, and when you subclass, you need to implement neither or both of__eq__and__hash__(see https://docs.python.org/3/reference/datamodel.html#object.__hash__)__eq__in the python layer, keeping theGeometryObject_richcomparein the C extension type inpygeos.c(but in principle we could also do it the other way around I think)