Clean-up old/unused files and scripts#1219
Merged
jorisvandenbossche merged 3 commits intoshapely:mainfrom Nov 29, 2021
Merged
Conversation
mwtoews
reviewed
Nov 8, 2021
Member
mwtoews
left a comment
There was a problem hiding this comment.
The DLLs_* directories are cross-referenced in setup.py and MANIFEST.in (via found git grep DLLs_). It might be easier to address changes to setup.py when it gets rewritten for the 2.0 merge. MANIFEST.in could be changed in this PR.
Otherwise I agree that all of these files should be cleaned up.
Member
Author
|
Good find, thanks! Will clean up those references. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up some (AFAIK) unused files in the repo.
All of those files were not touched for years, empty, or unused wheel build scripts (which are not used, since we have shapely-wheels). So I think all of them can be removed, but of course would be good if someone with more history in the project can check this.