Refactor STRtree implementation to store geoms/idx sequences instead of reverse mapping#1177
Merged
jorisvandenbossche merged 1 commit intoshapely:masterfrom Aug 21, 2021
Conversation
…of reverse mapping
Member
Author
|
cc @sgillies what do you think about this PR? |
sgillies
approved these changes
Aug 20, 2021
Contributor
sgillies
left a comment
There was a problem hiding this comment.
👍 thanks @jorisvandenbossche !
Contributor
|
I'll merge and then we could have another pre-release on Monday. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the implementation details from #1064 (i.e. using
geomsandidxssequences (lists) to store the data with which the GEOSSTRtree gets created, instead of using a mapping), but cleanly on top of the new interface (query_geoms/query_items) from #1112, without all the discussion on the interface from #1064.It doesn't change any user facing API now after #1112, but only refactors the implementation (how to store the items). As mentioned in #1112 (comment), this version is closer to what we would do in the shapely-2.0 branch on top of the C-based STRtree (which I started in #1161). IMO it is useful to already do this now (it will also make it a bit easier to have the master and shapely-2.0 branches next to each other for a while).