Only support separate geoms, items sequences in STRtree constructor#1172
Merged
sgillies merged 1 commit intoshapely:masterfrom Jul 26, 2021
Merged
Conversation
This was referenced Jul 17, 2021
sgillies
approved these changes
Jul 26, 2021
Contributor
sgillies
left a comment
There was a problem hiding this comment.
Thank you @jorisvandenbossche !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow-up on #1112. See my comment at #1112 (comment) about supporting zipped geoms/items sequence vs only supporting separate sequences.
Assuming the zipped sequences in #1112 were a left-over from the initial version of that PR, this PR updates the STRtree constructor (and tests) to:
STRtree(geoms, items), and thus no longer supportsSTRtree(zip(geoms, items))STRtree(None). This didn't work before in released versions, and IMO it's cleaner to keep requiringgeomsto be a sequence (it can still be an empty sequence)If the intention is to mainly support the separate sequences, I would personally not support the zipped sequences (i.e. sequence tuples) to keep the interface simple and explicit.