Expand CI and tests to support GEOS 3.9.0beta1#1041
Expand CI and tests to support GEOS 3.9.0beta1#1041mwtoews wants to merge 2 commits intoshapely:masterfrom
Conversation
|
The AppVeyor failure is a known issue with |
|
The CI scripts are now closer aligned to what I prepard for PyGEOS, which may allow them to be used with Github Actions, or other CI offerings. This will probably help future CI migrations. Another key difference is that I've disabled a failure from |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks a lot for looking at this!
| ('LINESTRING (1 1 1, 2 2)', 'LINESTRING (1 1, 2 2)'), | ||
| # preserve 3rd dimension | ||
| ('LINESTRING (1 1, 2 2 2)', 'LINESTRING Z (1 1 0, 2 2 2)'), | ||
| ] |
There was a problem hiding this comment.
It seems to be quite inconsistent when an incomplete third dimension is preserved and when it is dropped, right? And also the change with GEOS 3.9 does not seem to make it more consistent
There was a problem hiding this comment.
I call this a minor annoyance; see GEOS trac#1079
| self.assertSVG( | ||
| Point(7, 3).union(LineString([(4, 2), (8, 4)])), | ||
| GeometryCollection( | ||
| [Point(7, 3), LineString([(4, 2), (8, 4)])]), |
There was a problem hiding this comment.
This is indeed related to OverlayNG (I once tested this, but forgot to do a PR for shapely to fix it).
The order of the parts of the geometry collection changed
GEOS 3.9.0beta1 was recently announced, which should be paired with the Python 3.9 CI tests.
A few tests were refactored to accommodate the changes:
test_create_inconsistent_dimensionality.pysuite. I'm not sure if any of these are worth reporting upstream or not. The only exception is forLineString. Some additional tests and comments are added for completeness.unionchanged, likely a result of the new OverlayNGPOINT EMPTYandPOINT Z EMPTYare supported, so do an explicit test/xfail