With the release of 1.6.0, the geopandas tests started failing (we should really test with shapely master, or at least with beta/rc versions, sorry!)
I didn't look yet into detail what is going wrong, but I could already pin it down to:
In [6]: from shapely.geometry import Point
In [7]: from geopandas import GeoSeries
In [8]: s = GeoSeries([Point(1, 1), None])
In [9]: s.fillna(Point())
Out[9]:
0 POINT (1 1)
1 GEOMETRYCOLLECTION EMPTY
dtype: object
In [10]: import shapely
In [11]: shapely.__version__
Out[11]: '1.5.16'
vs
In [7]: from shapely.geometry import Point
In [8]: from geopandas import GeoSeries
In [9]: s = GeoSeries([Point(1, 1), None])
In [10]: s.fillna(Point())
Out[10]:
0 POINT (1 1)
1 None
dtype: object
In [11]: import shapely
In [12]: shapely.__version__
Out[12]: '1.6.0'
So the fillna method is no longer filling with an empty collection.
I have to further drill down into the fillna implementation to see where the difference happens, and what actual shapely behaviour changed(will try to do that tomorrow). But already putting this issue, in case anybody has an idea where it could be coming from.
With the release of 1.6.0, the geopandas tests started failing (we should really test with shapely master, or at least with beta/rc versions, sorry!)
I didn't look yet into detail what is going wrong, but I could already pin it down to:
vs
So the
fillnamethod is no longer filling with an empty collection.I have to further drill down into the fillna implementation to see where the difference happens, and what actual shapely behaviour changed(will try to do that tomorrow). But already putting this issue, in case anybody has an idea where it could be coming from.