Cc: @Karlson2k , @thesamesam

In case you want to test packaging it in Gentoo.

Is the changelog somewhere?

Changelog is in the 4.19.0-rc1 tag.

(Note, I merged this locally and pushed, in order to preserve the tag which I had pre-generated. I'm still trying to decide whether it's better to post this pr and merge through UI, then generate the tag and artifacts, but that's more duplication, since I do a 'make dist' before posting this PR in order to test...)

I'm getting:

[   23s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/shadow-4.19.0-build/shadow-4.19.0-rc1/src'
[   23s] gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -I.. -DLOCALEDIR=\"/usr/share/locale\" -DUSE_ECONF=1   -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fpie -c -o chsh.o chsh.c
[   23s] chsh.c: In function ‘shell_is_listed’:
[   23s] chsh.c:164:9: warning: ‘econf_readDirs’ is deprecated: Use the econf_readConfig/econf_readConfigWithCallback instead [-Wdeprecated-declarations]
[   23s]   164 |         error = econf_readDirs(&key_file,
[   23s]       |         ^~~~~
[   23s] In file included from chsh.c:45:
[   23s] /usr/include/libeconf.h:497:1: note: declared here
[   23s]   497 | econf_readDirs(econf_file **key_file,
[   23s]       | ^~~~~~~~~~~~~~
[   23s] chsh.c:175:17: error: too few arguments to function ‘fail_exit’; expected 2, have 1
[   23s]   175 |                 fail_exit (1);
[   23s]       |                 ^~~~~~~~~
[   23s] chsh.c:82:1: note: declared here
[   23s]    82 | fail_exit (int code, bool process_selinux)
[   23s]       | ^~~~~~~~~
[   23s] chsh.c:184:17: error: too few arguments to function ‘fail_exit’; expected 2, have 1
[   23s]   184 |                 fail_exit (1);
[   23s]       |                 ^~~~~~~~~
[   23s] chsh.c:82:1: note: declared here
[   23s]    82 | fail_exit (int code, bool process_selinux)
[   23s]       | ^~~~~~~~~
[   23s] make[2]: *** [Makefile:1180: chsh.o] Error 1

I'm getting:

[   23s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/shadow-4.19.0-build/shadow-4.19.0-rc1/src'
[   23s] gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -I.. -DLOCALEDIR=\"/usr/share/locale\" -DUSE_ECONF=1   -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fpie -c -o chsh.o chsh.c
[   23s] chsh.c: In function ‘shell_is_listed’:
[   23s] chsh.c:164:9: warning: ‘econf_readDirs’ is deprecated: Use the econf_readConfig/econf_readConfigWithCallback instead [-Wdeprecated-declarations]
[   23s]   164 |         error = econf_readDirs(&key_file,
[   23s]       |         ^~~~~
[   23s] In file included from chsh.c:45:
[   23s] /usr/include/libeconf.h:497:1: note: declared here
[   23s]   497 | econf_readDirs(econf_file **key_file,
[   23s]       | ^~~~~~~~~~~~~~
[   23s] chsh.c:175:17: error: too few arguments to function ‘fail_exit’; expected 2, have 1
[   23s]   175 |                 fail_exit (1);
[   23s]       |                 ^~~~~~~~~
[   23s] chsh.c:82:1: note: declared here
[   23s]    82 | fail_exit (int code, bool process_selinux)
[   23s]       | ^~~~~~~~~
[   23s] chsh.c:184:17: error: too few arguments to function ‘fail_exit’; expected 2, have 1
[   23s]   184 |                 fail_exit (1);
[   23s]       |                 ^~~~~~~~~
[   23s] chsh.c:82:1: note: declared here
[   23s]    82 | fail_exit (int code, bool process_selinux)
[   23s]       | ^~~~~~~~~
[   23s] make[2]: *** [Makefile:1180: chsh.o] Error 1

Hmmm, I see the bug. It seems to be hidden behind HAVE_VENDORDIR, which is why it wasn't detected before. @ikerexxe , would you mind checking this?

A fix should include:

Fixes: 24180caf2183 (2025-10-07; "src/chsh.c: SELinux file context for fail_exit()")

Fixed in #1414