Subid v3 #1351
Merged
Subid v3 #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ikerexxe
reviewed
Sep 3, 2025
Collaborator
ikerexxe
left a comment
There was a problem hiding this comment.
Just a minor comment inline.
In addition, as Alejandro already mentioned don't create a new PR when you fix the issues that we are highlighting. You can use git rebase -i and git push -f to fix the problems and push the changes.
1893db1 to
8dc6c62
Compare
Move 'want_sub[ug]ids' from 'src/newusers.c' to 'lib/subordinateio.[ch]' and rename them to 'want_sub[ug]id_file' to clearly indicate that it refers to the '/etc/sub[ug]id' and not to subids in general.
Use 'want_sub[ug]id_file' to short-circuit acess to '/etc/sub[ug]id' when nss-moduleis active
8dc6c62 to
2369b5e
Compare
Member
|
lgtm, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.