Changes for working with Shadow main branch#7
Merged
robgjansen merged 10 commits intoshadow:mainfrom Apr 23, 2021
Merged
Conversation
stevenengler
approved these changes
Apr 23, 2021
Comment on lines
+129
to
+132
| if "mem_available" in data[some_key]: | ||
| used = {float(ts): data[ts]["mem_total"] - data[ts]["mem_available"] for ts in data} | ||
| else: | ||
| used = {float(ts): data[ts]["mem_used"] for ts in data} |
Contributor
There was a problem hiding this comment.
Would it be useful to print a warning message in the 'else' case? It might be confusing if the memory usage calculation is different between computers. For example if the memory usage increased linearly on one computer but non-linearly on another, it might not be obvious that the reason for the discrepancy is the measurement method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.