Support new graph and config formats used by shadow#31
Merged
stevenengler merged 1 commit intoshadow:mainfrom Aug 23, 2021
Merged
Support new graph and config formats used by shadow#31stevenengler merged 1 commit intoshadow:mainfrom
stevenengler merged 1 commit intoshadow:mainfrom
Conversation
9a7847e to
a4c9fdd
Compare
a4c9fdd to
15da942
Compare
robgjansen
approved these changes
Aug 20, 2021
Member
robgjansen
left a comment
There was a problem hiding this comment.
Overall I think this is great! I'm really happy that you were able to compress and simplify the filtering logic compared to the C version.
You may want to add some comments, and double check the longest prefix match logic when two nodes have the same longest prefix from the ip address hint.
Contributor
Author
|
I also fixed the IP prefix match, which was incorrect since Python was interpreting the results of the bitwise operations as a signed integer rather than unsigned. |
7ca905c to
f28cfcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the new shadow graph and configuration formats. We now assign hosts directly to graph nodes rather than using hints like "country_code_hint" and "ip_address_hint", so we now need to read and use the network graph.
@robgjansen Let me know if you'd like me to rename any of the options or filenames. Also I think I replicated the host assignment logic to be the same as it is in shadow, but make sure it aligns with how you expect it to run,