Rearrange tor and tgen configuration files#17
Conversation
robgjansen
left a comment
There was a problem hiding this comment.
Looks plausible!
It's a bit hard to tell the structure of everything without actually running the code to generate a new config structure. Should I do that as a sanity check?
Also, do you think this change is big enough that we should run a trial Tor experiment to make sure the experiment runs as expected?
tornettools/generate_defaults.py
Outdated
| TGENRC_MARKOVCLIENT_DIRNAME="tgen-markov" | ||
| TGENRC_MARKOVCLIENT_FILENAME_FMT="{}.tgenrc.graphml" | ||
| TGENRC_MARKOVCLIENT_FILENAME="tgenrc.graphml" | ||
| TGENRC_FLOWMODEL_FILENAME_FMT="flowmodel.{}usec.graphml" |
There was a problem hiding this comment.
Nit: should we use this instead to be consistent with the stream and packet model names?
TGENRC_FLOWMODEL_FILENAME_FMT="tgen.tor-flowmodel-{}usec.graphml"
e499976 to
74f716a
Compare
I ran a 0.1% network and Shadow completed successfully. I'll run another one before merging and I'll double check that the log files look okay. Edit: I ran a 1% network for 30 sim minutes and everything looks fine to me. |
Closes #15, and also rearrange the tgen markov client configuration files to store them in the hosts directory rather than the conf directory.