Add graceful shutdowns for fixed-size streams#43
Merged
robgjansen merged 2 commits intoshadow:mainfrom Jan 23, 2023
Merged
Conversation
stevenengler
approved these changes
Jan 23, 2023
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
I'm not very familiar with tgen, but it seems good to me.
I think there's still technically a small race condition here where a tgen connection receives a footer message, sends its own footer message, and closes the socket while its outgoing footer message is still sitting in the socket's outgoing queue. But since the number of bytes will be small, there's a very high chance that it will be received by the tor client and sent on the circuit before the socket leaves the TIME_WAIT state, and so the tgen connection will be successful.
ac0eac6 to
d9242ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fixed-size streams where we know in advance what the send or recv length is going to be, we can do a graceful shutdown by sending application-layer FINs after we have read everything that the other side sent us. This helps ensure we don't close sockets before the data was actually received by the other end and lose data.
For non-fixed-sized streams that are driven only by a Markov model, the graceful shutdown procedure is skipped since the other end does not know when to expect the stream to end and where to look for the footer that contains the FIN.