Using older Rust nightly version for coverage tests#942
Merged
stevenengler merged 1 commit intoshadow:devfrom Aug 24, 2020
stevenengler:older-rust-nightly
Merged
Using older Rust nightly version for coverage tests#942stevenengler merged 1 commit intoshadow:devfrom stevenengler:older-rust-nightly
stevenengler merged 1 commit intoshadow:devfrom
stevenengler:older-rust-nightly
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #942 +/- ##
=======================================
Coverage 53.74% 53.74%
=======================================
Files 135 135
Lines 19452 19452
Branches 4831 4831
=======================================
Hits 10454 10454
Misses 5847 5847
Partials 3151 3151
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
sporksmith
approved these changes
Aug 24, 2020
Contributor
Author
|
@sporksmith This might be better than disabling the test entirely (let me know if you disagree). And you can ignore the failing lint test, it will be fixed in #940. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until #941 is resolved, this PR uses
nightly-2020-08-20for coverage tests.