Fix an empty path bug with most file -at syscall handlers#3661
Merged
stevenengler merged 2 commits intoshadow:mainfrom Sep 23, 2025
Merged
Fix an empty path bug with most file -at syscall handlers#3661stevenengler merged 2 commits intoshadow:mainfrom
stevenengler merged 2 commits intoshadow:mainfrom
Conversation
I haven't noticed a bug regarding this, but it seems wrong to treat files we store in memory and files without a valid OS fd as the current working directory. This change doesn't fix the behaviour, but returns an error instead of doing the wrong thing.
These didn't properly handle an empty path. I didn't fix 'regularfile_linkat' and 'regularfile_renameat2', and instead just left TODOs.
91c86f5 to
e67b652
Compare
sporksmith
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3659.