Unref the SysCallCondition before waking the thread#3652
Merged
stevenengler merged 5 commits intoshadow:mainfrom Sep 9, 2025
Merged
Unref the SysCallCondition before waking the thread#3652stevenengler merged 5 commits intoshadow:mainfrom
SysCallCondition before waking the thread#3652stevenengler merged 5 commits intoshadow:mainfrom
Conversation
7579000 to
4d846ba
Compare
4d846ba to
2b7d4c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the example in #3650 and fixes #3564. It unrefs the
SysCallConditionbefore we callhost_continuein the wakeup task. This allows us to unref itsOpenFile, otherwise the file cannot be closed untilhost_continue()finishes.Let me know if there's a nicer way to do this, but I don't see one.
The explanation of what's happening is in #3650 (comment). Lmk if that comment isn't very clear.